Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stage 3 proposal globalThis #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement stage 3 proposal globalThis #4

wants to merge 3 commits into from

Conversation

TommiTallgren
Copy link

This PR implements the stage 3 proposal globalThis.

  1. Actual implementation is 2 lines of code
  2. I've added a default enabled flag so it can be flagged off if ever necessary
  3. I've added a few tests which I think should be sufficient
  4. The large size of the diff is only due to it needing a byte code regen

cc: @ljharb @pleath

closes: chakra-core#1658

@softagram-bot
Copy link

Softagram Impact Report for pull/4 (head commit: 5b2093f)

⭐ Visual Overview

Changed elements and changed dependencies.
Changed dependencies - click for full size
Graph legend
(Open in Softagram Desktop for full details)

⭐ Change Impact

How the changed files are used by the rest of the project
Impacted files - click for full size
Graph legend
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback of this report to support@softagram.com

@ljharb
Copy link

ljharb commented Jan 7, 2019

Did you mean to open this on your fork?

@TommiTallgren
Copy link
Author

LjHarb:> Did you mean to open this on your fork?
Jordan, This was a test, planned to re-open on our own fork just to show the capabilities for the Softagram pull-request analysis for one of our customers. (please see the comment in the top)...

Impact analysis and visualization are for boosting the code reviews and faster understanding of the impacts of the change before the merge... Would you have been helped by that kind of analysis (we offer free analysis for Opensource projects)
Br,
Tommi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement global.global
4 participants
@TommiTallgren @softagram-bot @ljharb @rhuanjl